Fix: Add missing _label_overlap function and integrate into metrics#1246
Merged
mrariden merged 1 commit intoMouseLand:mainfrom Jun 27, 2025
mario-koddenbrock:fix_aggregated_jaccard_index
Merged
Fix: Add missing _label_overlap function and integrate into metrics#1246mrariden merged 1 commit intoMouseLand:mainfrom mario-koddenbrock:fix_aggregated_jaccard_index
_label_overlap function and integrate into metrics#1246mrariden merged 1 commit intoMouseLand:mainfrom
mario-koddenbrock:fix_aggregated_jaccard_index
Conversation
Implemented missing `_label_overlap` function required for accurate computation in `aggregated_jaccard_index`. Updated `aggregated_jaccard_index` and `_intersection_over_union` functions to utilize this helper function, ensuring consistency and correctness of metric calculations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 47.13% 48.96% +1.83%
==========================================
Files 16 16
Lines 3711 3762 +51
==========================================
+ Hits 1749 1842 +93
+ Misses 1962 1920 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented missing
_label_overlapfunction required for accurate computation inaggregated_jaccard_index. Updatedaggregated_jaccard_indexand_intersection_over_unionfunctions to utilize this helper function, ensuring consistency and correctness of metric calculations.