Qtpy refactor#760
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #760 +/- ##
==========================================
+ Coverage 63.26% 63.36% +0.10%
==========================================
Files 14 14
Lines 2962 2962
==========================================
+ Hits 1874 1877 +3
+ Misses 1088 1085 -3
|
Collaborator
Author
|
codecov is upset about decreased coverage, but tests are passing. GUI test on ubuntu linux works for me |
Collaborator
Author
|
I updated the install to use pyqt6 but allow pyqt5. I was getting an error related to qt not finding a dependency: which I fixed by finding the missing package using Not sure how big of an issue that will be for other linux users |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace PyQt5 dependency with more flexible qtpy library.
Test on: