Skip empty outlines and display a message in the console.#829
Merged
carsen-stringer merged 3 commits intoMouseLand:mainfrom Sep 7, 2024
Merged
Skip empty outlines and display a message in the console.#829carsen-stringer merged 3 commits intoMouseLand:mainfrom
carsen-stringer merged 3 commits intoMouseLand:mainfrom
Conversation
Skip empty outlines
Contributor
Author
Member
|
did the other PR fix this? |
Contributor
Author
|
Hi, not exactly. The other PR was just to ignore empty line in the imagej_roi_converter.py. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
==========================================
- Coverage 52.97% 52.76% -0.22%
==========================================
Files 18 18
Lines 4119 4126 +7
==========================================
- Hits 2182 2177 -5
- Misses 1937 1949 +12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a quick workaround for the issue #789 (and #708)
It doesn't address the root cause, why some outlines are empty, but at least it allows to export the ImageJ ROI file.
I'm not used to python, you might want to adjust the code.