added optional params cp_path and logfile_name to the setup_logger fu…#862
Merged
carsen-stringer merged 3 commits intoMouseLand:mainfrom Sep 7, 2024
Merged
Conversation
Member
|
thanks! I am also adding the train and test loss as outputs from |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
- Coverage 56.00% 52.97% -3.03%
==========================================
Files 17 18 +1
Lines 3875 4119 +244
==========================================
+ Hits 2170 2182 +12
- Misses 1705 1937 +232 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of my understanding, the only way to get information about the loss, is in the ~/.cellpose/run.log file.
For me (and probably for others too) I often start multiple runs in parallel. To have one log file per run, it would be useful to set a custom logging dir and logfile name in the function
logger_setupincellpose/io.py.I've added the optional params
cp_pathandlogfile_namewith the default values ".cellpose" and "run.log" (same values that are harcoded in the code)