Async tasks error witch PaperMC #280

[SharasGit]

Hello,

I was on PaperMC 273 1.15.2 without any issue, 7 worlds with Multiverse-core. Today, i upgraded to PaperMC 280 and when my server close, i have this error every time. I reported it to PaperMC, they told me to see with Multiverse.

[10:40:53] [Server thread/ERROR]: Nag author: 'Rigby' of 'Multiverse-Core' about the following: This plugin is not properly shutting down its async tasks when it is being shut down. This task may throw errors during the final shutdown logs and might not complete before process dies.

Thank you.

[Muspah]

Introduced here: PaperMC/Paper@55e17a8

[nicegamer7]

By any chance, did you run the version command before shutting down?

[SharasGit]

No. But i was able to reproduce easily the error by stopping too fast the server after starting it. When the server run for sometimes, i rarely have that error, but sometimes i got it.

[Muspah]

Only when stopping too fast? We're doing scheduled restarts (cronjob executing stop in tmux) every 24 hours, and it will almost always show the warning message.

[SharasGit]

I'm now using paper #334 with 7 worlds. I also do a cron every 24 hours, but i do not use the restart, i do a stop, wait a minute and start it after that. I still have the error, but no as often as with #280. Up until now, the error did not corrupt anything.

[nicegamer7]

Okay, thanks for the info. I've been hinted that it may be our metrics, so I'm working on implementing bStats. I'll post a test build once it's done and we'll see if you still get the warning.

[Muspah]

Same here indeed, nothing seems to get corrupted, no stacktraces or other errors too. It seems like a basic task hanging on e.g. an HTTP call. I first thought of some version checking, but Metrics sounds like a good one too.

[nicegamer7]

Alright, I've got a test build available here (merged). Please give it a try and let me know if it solves the issue for you.

[SharasGit]

I tested your build and i wasn't able to reproduce the error with it. I tried multiple times, even stopped the server right after the start, it stopped perfectly. I reinstalled 4.1.0 and was able to reproduce the error immediately. Look like you found the problem ;)

[nicegamer7]

Awesome! I'll open a PR then. Thanks for testing.