Ensure anchors are saved in a machine-readable way#2103
Merged
dumptruckman merged 1 commit intoOct 5, 2020
Merged
Conversation
`locationToString()` is primarily used by the AnchorManager to persist anchors to disk (the other use is for logging). In a locale that uses periods as decimal separator, this works fine and the anchors can be loaded when the server restarts. However, in a locale that doesn't use periods (but commas, for instance) this produces an `anchors.yml` that cannot be parsed when loaded. Tying the string formatting in `locationToString()` to an English locale makes it behave as expected, regardless of the external locale setting.
Contributor
Author
|
Looks like your CI setup doesn't like oraclejdk8 anymore. Something like this here: https://travis-ci.community/t/error-installing-oraclejdk8-expected-feature-release-number-in-range-of-9-to-14-but-got-8/3766 |
dumptruckman
changed the title
dumptruckman
approved these changes
Oct 5, 2020
dumptruckman
left a comment
dumptruckman
left a comment
Member
There was a problem hiding this comment.
Nice and simple. Sorry for the delay!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
locationToString()is primarily used by the AnchorManager to persistanchors to disk (the other use is for logging).
In a locale that uses periods as decimal separator, this works fine and
the anchors can be loaded when the server restarts.
However, in a locale that doesn't use periods (but commas, for instance)
this produces an
anchors.ymlthat cannot be parsed when loaded.Tying the string formatting in
locationToString()to an English localemakes it behave as expected, regardless of the external locale setting.
Fixes: #2102