load cloned world with doLoad() instead of addWorld() (fixes #2378)#2379
Merged
Conversation
nicegamer7
requested changes
Oct 1, 2020
nicegamer7
left a comment
nicegamer7
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Overall seems good. I just requested some style changes, nothing big.
nicegamer7
reviewed
Oct 1, 2020
Contributor
Author
|
Thanks a lot for the review. I addressed your comments. |
Contributor
Author
|
Not sure whether force-pushing was a good idea here. Github seems to be a bit confused now. Sorry. Hope that works for you. |
nicegamer7
requested changes
Oct 1, 2020
Member
|
Force pushing is fine. |
Member
|
Also just a note, usually it's good to create a new branch when making a PR instead of using master. |
Contributor
Author
|
You are right. Would have been way cleaner. Though, I created my fork only to create this PR. |
Contributor
Author
|
Hm, the travis build stopped while downloading something. Is there a way to re-trigger the build? |
benwoo1110
approved these changes
Oct 3, 2020
nicegamer7
approved these changes
Oct 3, 2020
Member
|
I figured out how to trigger a restart 👍. |
Member
|
Awesome. Thank you for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #2378
We actually can skip all the
WorldCreatorsetup done byaddWorld()as the cloned world is ready and just needs to be loaded. Just usingdoLoad()enables us to cleanly apply the copied properties, which is the intention of this patch.