Skip to content

Updated plugin.yml commands and some missing alias#2420

Merged
dumptruckman merged 1 commit into
Multiverse:masterfrom
benwoo1110:plugin.yml-update
Oct 5, 2020
Merged

Updated plugin.yml commands and some missing alias#2420
dumptruckman merged 1 commit into
Multiverse:masterfrom
benwoo1110:plugin.yml-update

Conversation

@benwoo1110

Copy link
Copy Markdown
Member

Not sure why the plugins.yml commands looks so messed up, so here is just a quick fix for it.

super(plugin);
this.setName("Multiverse Version");
this.setCommandUsage("/mv version " + ChatColor.GOLD + "-[bhp] [--include-plugin-list]");
this.setCommandUsage("/mv version " + ChatColor.GOLD + "[-b|-h|-p] [--include-plugin-list]");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the standard we use elsewhere?

Copy link
Copy Markdown
Member

@benwoo1110 benwoo1110 Oct 5, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most other command had the - inside the [] (so like [-s], tho this is the only instance there is multiple of them. I thought this looks clearer, bcu -[bph] could be misunderstood as doing -bhp and not -b or -h or -p

@dumptruckman dumptruckman merged commit c1a3d48 into Multiverse:master Oct 5, 2020
@dumptruckman dumptruckman added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/ label Oct 5, 2020
@benwoo1110 benwoo1110 deleted the plugin.yml-update branch October 5, 2020 08:23
@benwoo1110 benwoo1110 mentioned this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted https://hacktoberfest.digitalocean.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants