Fix issue where special chars cause PatternSyntaxException#2445
Merged
Conversation
Escape regex special chars for help command
benwoo1110
added
Bug: Confirmed
benwoo1110
added
the
State: Needs Review By Dev
Member
|
Does this break filtering? |
Member
Author
|
From my testing no, anyways it's going to be completely changed in ACF as well. |
Member
Author
|
@nicegamer7 can we merge this or smt? (want to delete my old mv forks 😅) |
nicegamer7
reviewed
Jul 16, 2021
nicegamer7
approved these changes
Jul 16, 2021
nicegamer7
left a comment
nicegamer7
left a comment
Member
There was a problem hiding this comment.
I was originally hesitant to merge this because I wasn't sure if the filter was meant to allow users to search using regex, but I came to the realization that I don't think anyone is searching for a command using regex lol.
Member
Author
|
nah, it was just sole to fix a internal regex parsing issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape regex special chars for help command, fixes #2433