The long awaited fix...#2557
Closed
benwoo1110 wants to merge 2 commits into
Closed
Conversation
This will break support for 1.14 and below. * Add minidev json dependency. * Remove use of travel agent.
* Remove use of deprecated EntityCreatePortalEvent * Move to use PortalCreateEvent for all nether portalForm checking.
benwoo1110
added
the
PR: Better Coding
|
Has this been awaiting a release for over a year now? |
Contributor
|
Are there any updates on this? (or on 5.0.0 in general) because it seems like 5.0.0 has already been "ready" for over a year now... |
2 tasks
Member
Author
|
Implementing in #2824 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2000. Finally!
With the use of 1.15 bukkit API (or above), there are updates to PortalCreateEvent which allows better checking of nether portal creation.
NOTE: this will require #2555 to be merged first for bukkit dependency update.