Add ReflectHelper class to better facilitate various reflection actions.#2586
Merged
Conversation
benwoo1110
added
PR: Better Coding
dumptruckman
reviewed
Mar 8, 2021
Comment on lines
+19
to
+26
| @Nullable | ||
| public static Class<?> getClass(String classPath) { | ||
| try { | ||
| return Class.forName(classPath); | ||
| } catch (ClassNotFoundException e) { | ||
| return null; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Hopefully we're not using this all the time as it is a relatively costly operation. Class.forName is "slow" and should an exception be thrown that will also slow this down quite a bit.
Member
There was a problem hiding this comment.
We might want to consider a caching strategy here.
Member
Author
There was a problem hiding this comment.
Yea we do store the result, it should only be used on started, then the results are stored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various methods to help facility reflection.