Improve worldname checks#2629
Closed
benwoo1110 wants to merge 3 commits into
Closed
Conversation
Make use of the new WorldNameChecker class.
Member
Author
|
example output: Test build: |
Member
|
I don't like the idea of allowing unsafe world names. I liked your idea where we check if the world is in the world container. Would that not work? |
Member
Author
|
It will work, just more work haha, but yea its possible. I can try to see if it works out in code. |
Member
|
Okay, sounds good. |
Member
|
Actually, I think I have a simple solution. A world name must not start with a Pretty sure that will ensure worlds stay within the server's directory. |
Member
Author
|
Yea config option isnt the way to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds config option to allow unsafe (e.g. / ) to be part of the world name. Those that know what they doing can use it for subdir worlds etc. Also, integrate the new world name restrictions from #2353 to WorldNameChecker to make things cleaner.