Skip to content

Fix storing incorrect data in config for currency#524

Merged
dumptruckman merged 1 commit into
Multiverse:masterfrom
kannndesu:fix/currency-config-not-working
Aug 29, 2019
Merged

Fix storing incorrect data in config for currency#524
dumptruckman merged 1 commit into
Multiverse:masterfrom
kannndesu:fix/currency-config-not-working

Conversation

@kannndesu

Copy link
Copy Markdown
Contributor

Fix Issue #515

@dumptruckman

Copy link
Copy Markdown
Member

Thank you for this!

@dumptruckman dumptruckman merged commit a659d3a into Multiverse:master Aug 29, 2019
@top-sekret

top-sekret commented Sep 2, 2019

Copy link
Copy Markdown

This patch broke the plugin for me with a NullPointerException on portal creation. It might be necessary to add a check whether the currency is null.

@kannndesu

Copy link
Copy Markdown
Contributor Author

This patch broke the plugin for me with a NullPointerException on portal creation. It might be necessary to add a check whether the currency is null.

Hey! I'm aware of that and I have made a fix, here's the PR #526, please merge when available! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants