Skip to content

Fix Portal Fill Issues#551

Merged
dumptruckman merged 5 commits into
masterfrom
fix_nether_portal_fill
Oct 5, 2020
Merged

Fix Portal Fill Issues#551
dumptruckman merged 5 commits into
masterfrom
fix_nether_portal_fill

Conversation

@nicegamer7

Copy link
Copy Markdown
Member

This PR fixes the orientation of the nether_portal blocks placed along the z-axis when filling a portal using flint and steel. This closes #549.

when using physics with nether_portal blocks, errors are given when they are broken. so for now, we'll stick to not using physics.
@nicegamer7 nicegamer7 changed the title Fix Nether Portal Fill Orientation on Z-Axis Fix Portal Fill Issues May 16, 2020
@nicegamer7

Copy link
Copy Markdown
Member Author

I've just added two commits:

  • The first makes sure to use physics on all fill materials except the nether_portal block. The reason for this is that Spigot says in their Javadocs that setting it to false is generally unsafe. The only reason I've set it to false for nether_portal blocks is because after the portal is filled, if the blocks are broken, the console will send an error like this:
    [Server thread/ERROR]: POI data mismatch: never registered at BlockPosition{x=1614, y=64, z=-217}
  • The second fixes filling portals with air via an empty bucket. The issue was that the clicked block location was being translated away from the portal, towards the user. But because PlayerBucketFillEvent returns the block that filled the bucket, there was no need to translate the location.

I've tested all these changes on 1.13.2, 1.14.4, and 1.15.2, and they are all working as expected. Lava/Water do not flow, nether_portal blocks are rotated if needed, and portals are filled with air when an empty bucket is filled.

Comment thread src/main/java/com/onarandombox/MultiversePortals/listeners/MVPPlayerListener.java Outdated
Comment thread src/main/java/com/onarandombox/MultiversePortals/utils/PortalFiller.java Outdated
Comment thread src/main/java/com/onarandombox/MultiversePortals/listeners/MVPPlayerListener.java Outdated

@dumptruckman dumptruckman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@dumptruckman dumptruckman merged commit 862eae6 into master Oct 5, 2020
@dumptruckman dumptruckman deleted the fix_nether_portal_fill branch October 5, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filling a Portal with Flint and Steel on Z Axis

2 participants