Add config option for nether animation#644
Merged
Merged
Conversation
Member
|
Can you rebase this just so that the actions run. Other than that, LGTM. I think this is better solution than listening for the EntityPortalEnterEvent. |
benwoo1110
force-pushed
the
nether-animation
branch
from
184bb24 to
33370a1
Compare
Member
Author
|
okay done |
nicegamer7
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the config option as explained in #584 (comment). I opt to set the animation to true by default following Minecraft's standard behvaiour.