This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Claim zaps in batches#1203
Merged
Merged
Conversation
Contributor
|
When does the dm sync timestamp saved? |
Collaborator
Author
|
After an individual ecash notification is handled: mutiny-node/mutiny-core/src/hermes.rs Line 764 in ed3731a |
Contributor
I don't know what that means. When in the lifetime of an ecash redemption does this even take place? I guess instead of asking, I should specify that if we're going to move the redemption of the ecash to a batcahable thing in the end, then the timestamp should only be saved once the batched ecash completes fully. |
ed3731a to
ba618ee
Compare
Collaborator
Author
|
I see what you're saying, moved it to set the timestamp after the batch, that should be safer |
ba618ee to
94ef7e8
Compare
AnthonyRonning
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with #1163
Before we'd claim each zap individually and this could cause problems because relays would send the events with the newest first, so if we stopped claiming the zaps for whatever reason (user closes app), then we'd miss the remaining zaps because we'd set our sync timestamp to the first one we claimed. This fixes this problem by instead accumulating all the zaps until we get the End Of Stored Events message from the relays, and then claiming the zaps, this way we know we got everything from the relay.