This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Return channel open errors to user#1224
Merged
Merged
Conversation
benthecarman
force-pushed
the
ln-chan-errs
branch
from
be99525 to
b1ae845
Compare
benthecarman
commented
Jun 18, 2024
| @@ -524,8 +524,19 @@ impl<S: MutinyStorage> EventHandler<S> { | |||
| } => { | |||
| // if we still have channel open params, then it was just a failed channel open | |||
| // we should not persist this as a closed channel and just delete the channel open params | |||
Collaborator
Author
There was a problem hiding this comment.
i need to edit this comment
AnthonyRonning
approved these changes
Jun 18, 2024
AnthonyRonning
left a comment
AnthonyRonning
left a comment
Contributor
There was a problem hiding this comment.
awesome. i'm guessing this would work for channel amount too low errors too?
Collaborator
Author
|
Yeah I assume so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1220
Now exposes the channel open error message to the user