TX: Weatherization Assistance Program Discovery#1425
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Program config & import data programs/management/commands/import_program_config_data/data/tx_wap_initial_config.json |
New JSON adds TX WAP initial program config: white_label.code = "tx", program_category.external_name = "tx_housing", year 2025, legal-status requirements, names/descriptions, apply/learn URLs, estimated times/values, warning_message: null, required documents list, and navigators (211_texas). |
Program specification programs/programs/tx/wap/spec.md |
New Markdown spec for TX WAP (research date 2026-03-19): enumerates eligibility criteria (income ≤200% FPL, categorical paths including SSI/TANF/LIHEAP, residency by zipcode/county), notes dwelling-related data gaps, adds a has_liheap screener field, lists a $372/year benefit estimate, implementation coverage, 10 acceptance scenarios and 10 test scenarios, and source links. |
Validation fixtures validations/management/commands/import_validations/data/tx_wap.json |
New JSON fixture with three test households: (1) eligible via monthly Social Security income, (2) ineligible due to wages >200% FPL, (3) eligible via SNAP categorical eligibility. Each case includes household metadata, members, incomes, and expected tx_wap results. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The PR description provides only program details (name, state, white label, research date) but omits required template sections including Context & Motivation, Changes Made, Testing, Deployment, and Notes for Reviewers. | Complete the PR description using the provided template: add context/motivation explaining why this discovery work was needed, detail all files added, specify any testing/deployment steps, and note any reviewer considerations. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the primary change: adding discovery/specification work for Texas's Weatherization Assistance Program, matching the actual changeset. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
pat/mfb-675-tx-add-weatherization-assistance-program
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Remove selection priority criteria (elderly, disabled, children, energy burden) from eligibility section - Mark dwelling type as data gap (not collected in TX screener) - Remove administrative criteria: landlord permission, income docs, health/safety inspection, acquisition/demolition, local subgrantee - Update citizenship criterion: WAP has no federal citizenship restriction; all immigration statuses eligible; handled by front-end filtering - Move landlord permission and rental multi-unit rules into program description - Update implementation coverage counts (6 evaluable, 3 data gaps)
…nergy savings Replaces placeholder with $372/year estimate derived from DOE's published average annual energy savings figure, consistent with CO ($350) and NC ($300) WAP implementations in the codebase.
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@programs/management/commands/import_program_config_data/data/tx_wap_initial_config.json`:
- Line 20: The estimated_value field in the TX WAP JSON config is empty and
should be set to the committed WAP amount; update the "estimated_value" key in
tx_wap_initial_config.json to the string value "$372/year" so downstream
surfaces display the benefit value correctly.
In `@programs/programs/tx/wap/spec.md`:
- Around line 89-91: Remove the non-research "page chrome" links from the
references list by deleting the entries with link texts "[Skip the navigation]"
and "[Site map]" so only substantive research/source links remain in the
references section; ensure no other formatting or ordering is broken when
removing these two list items.
- Line 266: Replace the unhyphenated compound modifier "high energy burden" in
the multi-member household description (the sentence listing priority
categories: elderly, disabled, children, high energy burden) with the hyphenated
form "high-energy burden" so the compound modifier is grammatically correct.
- Around line 94-104: The spec still frames scenarios around removed
selection-priority criteria (elderly/disabled/children/high-energy-burden);
update the scenario list and related sections to remove any priority-based
wording and ensure scenarios only assert eligibility/outcome based on the final
eligibility rules. Specifically, edit the scenario descriptions (e.g., "Scenario
1" through "Scenario 11") and the other referenced blocks (around the ranges
noted) to strip terms like "priority", "elderly priority", "priority-based", and
any language implying selection tiers, replacing them with neutral eligibility
statements tied to explicit factors (income, residency, age thresholds,
SNAP/SSI, ZIP/rural) and keep outcomes (eligible/ineligible and $372/year)
intact. Ensure headers and any explanatory text elsewhere in the document no
longer describe priority-based acceptance criteria so the spec matches the PR
objective that selection-priority criteria were removed.
- Line 224: Scenario 8 in the spec uses the Texas ZIP "73301" for the "not a
Texas resident" exclusion, which makes the scenario ambiguous; update the
scenario's ZIP value (replace "73301" wherever referenced in Scenario 8) with a
clearly non‑Texas ZIP (e.g., "10001" or another confirmed out‑of‑state ZIP) so
the screener unambiguously treats the participant as non‑Texas; ensure any
related instruction text (Scenario 8) mentions the new ZIP and that if the
screener asks for state you still select a non‑Texas state.
In `@validations/management/commands/import_validations/data/tx_wap.json`:
- Line 64: The fixture uses the wrong program_name string so the exact-match
lookup in validate.py (line with if program["external_name"] ==
validation.program_name) fails; update the three expected_results blocks in the
tx_wap JSON fixture where "program_name" is "tx_weatherization assistance
program" to instead be "tx_wap" so the validation.lookup matches the program's
external_name and the scenarios are exercised.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: MyFriendBen/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ff19687d-4faa-4225-a4bb-e6b674102b86
📒 Files selected for processing (3)
programs/management/commands/import_program_config_data/data/tx_wap_initial_config.jsonprograms/programs/tx/wap/spec.mdvalidations/management/commands/import_validations/data/tx_wap.json
programs/management/commands/import_program_config_data/data/tx_wap_initial_config.json
Show resolved
Hide resolved
validations/management/commands/import_validations/data/tx_wap.json
Outdated
Show resolved
Hide resolved
- Remove out-of-state scenario (residency enforced by platform design via TX-only ZIP codes) - Fix validation program_name from "tx_weatherization assistance program" to "tx_wap" to match external_name (critical: was causing all 3 validation scenarios to be skipped) - Remove page-chrome links from research references - Hyphenate "high-energy burden" compound modifier - Renumber scenarios 9-11 → 8-10 after removal
programs/management/commands/import_program_config_data/data/tx_wap_initial_config.json
Outdated
Show resolved
Hide resolved
programs/management/commands/import_program_config_data/data/tx_wap_initial_config.json
Outdated
Show resolved
Hide resolved
programs/management/commands/import_program_config_data/data/tx_wap_initial_config.json
Outdated
Show resolved
Hide resolved
programs/management/commands/import_program_config_data/data/tx_wap_initial_config.json
Outdated
Show resolved
Hide resolved
…_link - Improve description: merge opening sentences, add process walkthrough (waitlist → auditor → contractor → inspector), clarify multi-unit renter language, add apply instructions for Help for Texans page - Fix learn_more_link to working TDHCA URL - Update apply_button_link to tdhca.texas.gov/help-for-texans - Clear apply_button_description
- Remove SNAP as categorical eligibility (not listed in 10 CFR 440.22) - Add LIHEAP as categorical eligibility per 10 CFR 440.22(a)(3) - Tighten SSI/TANF sources to cite 10 CFR 440.22(a)(2) precisely - Remove unsupported citizenship/immigration criterion - Remove primary residence criterion (no valid source cited) - Update TDHCA URL to current site (tdhca.texas.gov) - Update implementation coverage counts
Program Details
Summary by CodeRabbit
New Features
Documentation
Tests