[TASK] Drop support for vendor-prefixed keyframe selectors#1175
Closed
oliverklee wants to merge 1 commit into
Closed
[TASK] Drop support for vendor-prefixed keyframe selectors#1175oliverklee wants to merge 1 commit into
oliverklee wants to merge 1 commit into
Conversation
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
requested changes
Mar 16, 2025
JakeQZ
left a comment
JakeQZ
left a comment
Collaborator
There was a problem hiding this comment.
It just so happens that the keyframes test was written with a vendor prefix, and no equivalent test was written without a vendor prefix. We shouldn't remove this test (but could change it not to use vendor prefixes, or, perhaps better, add an equivalent test which does not use vendor prefixes). We don't need to remove support for vendor prefixes here, as it is not actually costing us anything. See #1174 (review).
Collaborator
Author
|
Okay, closing this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.