Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ Please also have a look at our

### Removed

- Remove `Rule::getColNo()` (use `getColumnNumber()` instead) (#1287)
- Passing a string as the first argument to `getAllValues()` is no longer
supported and will not work;
the search pattern should now be passed as the second argument (#1243)
Expand Down
8 changes: 0 additions & 8 deletions src/Position/Position.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@ public function getColumnNumber(): ?int
return $this->columnNumber;
}

/**
* @return int<0, max>
*/
public function getColNo(): int
{
return $this->getColumnNumber() ?? 0;
}

/**
* @param int<0, max>|null $lineNumber
* @param int<0, max>|null $columnNumber
Expand Down
7 changes: 0 additions & 7 deletions src/Position/Positionable.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ public function getLineNo(): int;
*/
public function getColumnNumber(): ?int;

/**
* @return int<0, max>
*
* @deprecated in version 8.9.0, will be removed in v9.0. Use `getColumnNumber()` instead.
*/
public function getColNo(): int;

/**
* @param int<0, max>|null $lineNumber
* Providing zero for this parameter is deprecated in version 8.9.0, and will not be supported from v9.0.
Expand Down
32 changes: 0 additions & 32 deletions tests/UnitDeprecated/Position/PositionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -77,38 +77,6 @@ public function getLineNoReturnsZeroAfterLineNumberCleared(): void
self::assertSame(0, $this->subject->getLineNo());
}

/**
* @test
*/
public function getColNoInitiallyReturnsZero(): void
{
self::assertSame(0, $this->subject->getColNo());
}

/**
* @test
*
* @dataProvider provideColumnNumber
*/
public function getColNoReturnsColumnNumberSet(int $columnNumber): void
{
$this->subject->setPosition(1, $columnNumber);

self::assertSame($columnNumber, $this->subject->getColNo());
}

/**
* @test
*/
public function getColNoReturnsZeroAfterColumnNumberCleared(): void
{
$this->subject->setPosition(1, 99);

$this->subject->setPosition(2);

self::assertSame(0, $this->subject->getColNo());
}

/**
* @test
*/
Expand Down