Skip to content

[BUGFIX] Allow order-insensitve removeDeclarationBlockBySelector#1406

Merged
oliverklee merged 2 commits into
mainfrom
task/remove-remove-declaration-block-loose
Dec 4, 2025
Merged

[BUGFIX] Allow order-insensitve removeDeclarationBlockBySelector#1406
oliverklee merged 2 commits into
mainfrom
task/remove-remove-declaration-block-loose

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Dec 4, 2025

Copy link
Copy Markdown
Collaborator

Also internally avoid comparison with ==.

Resolves #1330

@JakeQZ JakeQZ self-assigned this Dec 4, 2025
@JakeQZ JakeQZ added cleanup refactor For PRs that refactor code without changing functionality labels Dec 4, 2025
@JakeQZ JakeQZ marked this pull request as draft December 4, 2025 01:13
@coveralls

coveralls commented Dec 4, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 62.706% (+0.2%) from 62.487%
when pulling 52cd175 on task/remove-remove-declaration-block-loose
into 51a3c0a on main.

Also internally avoid comparison with `==`.

Resolves #1330
@JakeQZ JakeQZ changed the title [TASK] Lose loose comparison in removeDeclarationBlockBySelector [BUGFIX] Allow order-insensitve removeDeclarationBlockBySelector Dec 4, 2025
@JakeQZ JakeQZ marked this pull request as ready for review December 4, 2025 12:32
Comment thread src/CSSList/CSSList.php Outdated
@JakeQZ JakeQZ force-pushed the task/remove-remove-declaration-block-loose branch from 41605d1 to 52cd175 Compare December 4, 2025 16:08
@JakeQZ JakeQZ requested a review from oliverklee December 4, 2025 16:11

@oliverklee oliverklee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oliverklee oliverklee merged commit dc99bbd into main Dec 4, 2025
23 checks passed
@oliverklee oliverklee deleted the task/remove-remove-declaration-block-loose branch December 4, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup refactor For PRs that refactor code without changing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve loose comparison in removeDeclarationBlockBySelector()

3 participants