[TASK] Avoid heredoc in another test#1411
Merged
Merged
Conversation
JakeQZ
reviewed
Dec 4, 2025
JakeQZ
left a comment
JakeQZ
left a comment
Collaborator
There was a problem hiding this comment.
Could we also indent the contents of the string, etc., as part of this change? It would make the code easier to read.
I don't think the extra whitepsace should matter for the tests - the change as proposed may already be introducing or removing line-feeds (or maybe not - I'm not sure).
If it does matter, would it be possible to use string concatenation - or is that not an option for a constant in PHP 7.2?
This allows the testcase being autoformatted without breaking the tests for PHP 7.2. https://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc
Collaborator
Author
|
If I change the indentation, some tests will fail. I'll try concatenated strings next. |
oliverklee
force-pushed
the
cleanup/heredoc-2
branch
from
9617915 to
551f210
Compare
JakeQZ
approved these changes
Dec 5, 2025
JakeQZ
left a comment
JakeQZ
left a comment
Collaborator
There was a problem hiding this comment.
Some of the tests are unnecessarily whitespace-dependent :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the testcase being autoformatted
without breaking the tests for PHP 7.2.
https://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc