Skip to content

[DEVELOPER] Disallow 'heredoc' and 'nowdoc' for strings#1415

Merged
oliverklee merged 1 commit into
mainfrom
developer/disallow-heredoc
Dec 8, 2025
Merged

[DEVELOPER] Disallow 'heredoc' and 'nowdoc' for strings#1415
oliverklee merged 1 commit into
mainfrom
developer/disallow-heredoc

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

Part of #1412.

@JakeQZ JakeQZ requested a review from oliverklee December 8, 2025 19:37
@JakeQZ JakeQZ self-assigned this Dec 8, 2025
@JakeQZ JakeQZ added the developer-specific Issues that only affect maintainers, contributors, and people submitting PRs label Dec 8, 2025
@JakeQZ JakeQZ mentioned this pull request Dec 8, 2025
3 tasks
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 62.745%. remained the same
when pulling 61fff84 on developer/disallow-heredoc
into 21712cc on main.

@oliverklee oliverklee merged commit 400edb2 into main Dec 8, 2025
23 checks passed
@oliverklee oliverklee deleted the developer/disallow-heredoc branch December 8, 2025 20:18
@oliverklee

Copy link
Copy Markdown
Collaborator

Would you be willing to port this to Emogrifier as well?

@JakeQZ

JakeQZ commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator Author

Would you be willing to port this to Emogrifier as well?

MyIntervals/emogrifier#1534

Wondering if there's a way of sharing the config file between projects...

oliverklee pushed a commit to MyIntervals/emogrifier that referenced this pull request Dec 9, 2025
@oliverklee

Copy link
Copy Markdown
Collaborator

Wondering if there's a way of sharing the config file between projects...

We'd probably need to set up (and maintain) a third project with the config files, and then add that package as a development dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-specific Issues that only affect maintainers, contributors, and people submitting PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants