Skip to content

[CLEANUP] Tighten consumeUntil $comments parameter type#1418

Merged
oliverklee merged 1 commit into
mainfrom
cleanup/consumeuntil-comments-type
Dec 9, 2025
Merged

[CLEANUP] Tighten consumeUntil $comments parameter type#1418
oliverklee merged 1 commit into
mainfrom
cleanup/consumeuntil-comments-type

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Dec 9, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@JakeQZ JakeQZ requested a review from oliverklee December 9, 2025 12:39
@JakeQZ JakeQZ self-assigned this Dec 9, 2025
@JakeQZ JakeQZ added the cleanup label Dec 9, 2025
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 62.804%. remained the same
when pulling 1d40e28 on cleanup/consumeuntil-comments-type
into d1af3bb on main.

@oliverklee oliverklee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@oliverklee oliverklee merged commit a5d1172 into main Dec 9, 2025
23 checks passed
@oliverklee oliverklee deleted the cleanup/consumeuntil-comments-type branch December 9, 2025 12:43
@JakeQZ

JakeQZ commented Dec 9, 2025

Copy link
Copy Markdown
Collaborator Author

Seems that DeclarationBlock::parseSelectors() is the only place where the $comments parameter of comsumeUntil() is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants