[TASK] Ensure PHP 8.4 compatibility for nullable parameters#643
Merged
Conversation
Ensure that parameters that have a `null` default value also have `null` as part of their type declarations. Also ensure a uniform notation for nullable types. https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Fixes #634
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
sabberworm
approved these changes
Jul 4, 2024
Collaborator
|
I just reviewed this in the sister project, and found no need for the PHP-CS-Fixer config change. I am now confused. |
oliverklee
added a commit
that referenced
this pull request
Oct 27, 2024
This fixes compatibility with PHP 8.4. This is the last part of the v8.x backport of #643.
JakeQZ
pushed a commit
that referenced
this pull request
Oct 27, 2024
This fixes compatibility with PHP 8.4. This is the last part of the v8.x backport of #643.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that parameters that have a
nulldefault value also havenullas part of their type declarations.Also ensure a uniform notation for nullable types.
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Fixes #634