[TASK] Prepare the 8.7.0 release#742
Conversation
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Does now work with Emogrifier-dev on PHP 8.4?
|
Sigh. It seems we still need to fix some more places after all for PHP 8.4 compatibility for Emogrifier. (I wonder why the tests for PHP-CSS-Parser do not catch this.) |
Possibly needs something for #677.
That is indeed strange, since we are running unit tests with PHP 8.4, which will surely call |
Indeed: #744 |
oliverklee
force-pushed
the
task/release
branch
from
c1c4ec6 to
2ea1413
Compare
oliverklee
force-pushed
the
task/release
branch
from
2ea1413 to
635162e
Compare
|
Sigh. And another nullable-by-default parameter that isn't covered by the the parser tests yet: https://github.com/MyIntervals/emogrifier/actions/runs/11538536814/job/32117129042?pr=1304 |
oliverklee
force-pushed
the
task/release
branch
from
635162e to
bff0e82
Compare
|
Now the Emogrifier CI build is green with the latest changes in the v8.x branch of PHP-CSS-Parser: MyIntervals/emogrifier#1304 I think 8.7.0 is ready to get released. |
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Now the Emogrifier CI build is green with the latest changes in the v8.x branch of PHP-CSS-Parser: MyIntervals/emogrifier#1304
PHPUnit with dependencies=lowest is still failing but that's due to an issue with Symfony.
|
I have just released version 8.7.0: https://github.com/MyIntervals/PHP-CSS-Parser/releases/tag/v8.7.0 |
…into fix/malformed-identifier * 'v8.x' of https://github.com/MyIntervals/PHP-CSS-Parser: (46 commits) [CLEANUP] Autoformat the code (MyIntervals#749) [TASK] Prepare the 8.7.0 release (MyIntervals#742) [BUGFIX] Fix another implictly nullable parameter (MyIntervals#751) [CLEANUP] Autoformat the changelog (MyIntervals#750) [TASK] Configure PHPUnit to be more strict (MyIntervals#744) [BUGFIX] Avoid implicit nullable parameters (MyIntervals#746) [BUGFIX] Revert broken support for multiple comments (MyIntervals#741) [TASK] Add some more tests for parsing comments (MyIntervals#739) [TASK] Use fixed PHPUnit versions (MyIntervals#726) [TASK] Update PHPUnit (MyIntervals#725) [TASK] State since which version code is `@internal`/`@deprecated` (MyIntervals#723) [TASK] Deprecate the expansion of shorthand properties (MyIntervals#719) [TASK] Mark parsing-internal classes and methods as `@internal` (MyIntervals#711) [TASK] Deprecate `Parser::setCharset()` and `Parser::getCharset()` (MyIntervals#703) [FEATURE] Run the tests on CI with PHP 8.4 as well (MyIntervals#701) [TASK] Run the tests with PHP versions up to 8.3 (MyIntervals#697) [TASK] Also allow higher versions of PHPUnit (MyIntervals#682) [BUGFIX] Fix type errors in PHP strict mode (MyIntervals#695) [TASK] Block installations on unsupported higher PHP versions (MyIntervals#692) [BUGFIX] Avoid using `setUp()` in testcases (MyIntervals#683) ...
2 participants
No description provided.