[TASK] Configure PHPUnit to be more strict#743
Conversation
This is the v8.x backport of #743.
This is the v8.x backport of #743.
77f9b0f to
3a95a1c
Compare
This is the v8.x backport of #743.
JakeQZ
left a comment
There was a problem hiding this comment.
Changes seem mostly fine, but could we please keep the original indentation style. This would make the diff cleaner, and avoid attributes being idented by 9 spaces.
Also, do we need bootstrap="vendor/autoload.php". It seems to work without it, and must presumably be using that by default, otherwise the classes to be tested wouldn't load. Explicitly stating it creates a hard-coded value that makes assumptions about the behaviour of a third-party package (Composer itself). If PHPUnit effectively deals with the location of Composer's autoload file, then we should just allow it to do so.
This is the v8.x backport of #743.
|
Done and repushed. |
JakeQZ
left a comment
There was a problem hiding this comment.
I see clearly now we already had cacheResult="false" in this project :)
This is the v8.x backport of #743.
This is the v8.x backport of #743.
This is the v8.x backport of #743.
This change brings the PHPUnit configuration in line with what we have at Emogrifier (except for the difference in the XSD version number).