Skip to content

fix: set default to 1 day for assimilation period for MOM6#1032

Merged
hkershaw-brown merged 2 commits intomainfrom
default-assim-period
Jan 6, 2026
Merged

fix: set default to 1 day for assimilation period for MOM6#1032
hkershaw-brown merged 2 commits intomainfrom
default-assim-period

Conversation

@hkershaw-brown
Copy link
Member

Description:

Sets default to 1 day for assimilation period for MOM6
Also input.nml in work directory to match default

Fixes issue

fixes #1029

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

The documentation lists 1 day in the example input.nml
assimilation_period_days = 1
assimilation_period_seconds = 0

Tests

MOM6 filter run.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown added mom6 Modular Ocean Model release+1 bundle with release after next labels Jan 6, 2026
Copy link
Contributor

@mgharamti mgharamti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I never noticed these defaults!

@hkershaw-brown
Copy link
Member Author

hkershaw-brown commented Jan 6, 2026 via email

input.nml in work directory to match default
fixes #1029
@hkershaw-brown hkershaw-brown merged commit adaae94 into main Jan 6, 2026
4 checks passed
@hkershaw-brown hkershaw-brown deleted the default-assim-period branch January 6, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mom6 Modular Ocean Model release+1 bundle with release after next

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Default values for assimilation_period_{days|seconds} for MOM6 are -1 which is not allowed in DART.

2 participants