fix: set default to 1 day for assimilation period for MOM6#1032
Merged
hkershaw-brown merged 2 commits intomainfrom Jan 6, 2026
Merged
fix: set default to 1 day for assimilation period for MOM6#1032hkershaw-brown merged 2 commits intomainfrom
hkershaw-brown merged 2 commits intomainfrom
Conversation
mgharamti
approved these changes
Jan 6, 2026
Contributor
mgharamti
left a comment
There was a problem hiding this comment.
Looks good. I never noticed these defaults!
Member
Author
|
me neither!
…On Tue, Jan 6, 2026 at 2:44 PM Moha Gharamti ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good. I never noticed these defaults!
—
Reply to this email directly, view it on GitHub
<#1032 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEY6JH5RZ3LUONGI6XCHGVT4FQGDPAVCNFSM6AAAAACQ3W6NOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMZSGI2DQNZTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
input.nml in work directory to match default fixes #1029
9fe6af3 to
2fe934c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Sets default to 1 day for assimilation period for MOM6
Also input.nml in work directory to match default
Fixes issue
fixes #1029
Types of changes
Documentation changes needed?
The documentation lists 1 day in the example input.nml
assimilation_period_days = 1
assimilation_period_seconds = 0
Tests
MOM6 filter run.
Checklist for merging
Checklist for release
Testing Datasets