Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
97d6360
start api changes
valeriupredoi Feb 25, 2025
d4f0588
start api changes
valeriupredoi Feb 25, 2025
3b6f0ce
set structure
valeriupredoi Feb 26, 2025
bf0c3fd
add test
valeriupredoi Feb 26, 2025
35a29d5
actual test with pyfive variable
valeriupredoi Feb 26, 2025
28d97e5
actual test with pyfive variable
valeriupredoi Feb 26, 2025
25668bd
clean up
valeriupredoi Feb 26, 2025
8cdd4cb
clean up and add bits
valeriupredoi Feb 26, 2025
a2f41ab
add chunking test case
valeriupredoi Feb 26, 2025
e471dee
add exception if not pyfive dataset
valeriupredoi Feb 27, 2025
620e2b6
test for that exception
valeriupredoi Feb 27, 2025
dca443f
start reduce chunk with correct syntax
valeriupredoi Feb 27, 2025
1bd40f5
it bloody works
valeriupredoi Feb 27, 2025
0bdc310
it bloody works
valeriupredoi Feb 27, 2025
9f46ab9
add inline comment
valeriupredoi Feb 27, 2025
0c562e1
correct handling for s3
valeriupredoi Feb 27, 2025
74f0c26
run s3 tests
valeriupredoi Feb 27, 2025
51e27ca
add real world s3 dataset test
valeriupredoi Feb 27, 2025
2499066
add note to test
valeriupredoi Feb 27, 2025
c495019
remove leftover
valeriupredoi Feb 27, 2025
ad3fb54
unused import
valeriupredoi Feb 27, 2025
9bf31bd
unused return
valeriupredoi Feb 27, 2025
61cf5dd
add correct function docstring
valeriupredoi Feb 28, 2025
4cdeb1b
removed obsolete inline
valeriupredoi Feb 28, 2025
9aca259
remove obsolete inline
valeriupredoi Feb 28, 2025
2507fe4
Update activestorage/active.py
valeriupredoi Feb 28, 2025
17684aa
Update activestorage/active.py
valeriupredoi Feb 28, 2025
b80862d
Update activestorage/active.py
valeriupredoi Feb 28, 2025
ebd54e8
fix test
valeriupredoi Feb 28, 2025
050bc8f
test mock s3 dataset
valeriupredoi Feb 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update activestorage/active.py
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
  • Loading branch information
valeriupredoi and davidhassell authored Feb 28, 2025
commit b80862d805916ef20e3c7b7db29cdbb65edf5c97
2 changes: 1 addition & 1 deletion activestorage/active.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def __init__(
if dataset is None:
raise ValueError(f"Must use a valid file name or variable object for dataset. Got {dataset!r}")
if isinstance(dataset, Path) and not dataset.exists():
raise ValueError(f"Path to input file {dataset} does not exist.")
raise ValueError(f"Path to input file {dataset!r} does not exist.")
if not isinstance(dataset, Path) and not isinstance(dataset, str):
print(f"Treating input {dataset} as variable object.")
if not type(dataset) is pyfive.high_level.Dataset:
Expand Down