Refactor of source retrieval provenance model#388
Conversation
Adding RetrievalSource object (and a reference to it form Edge) to support richer representations of retrieval provenance per NCATSTranslator#369.
| an Edge. Note that a given Edge should have one and only one 'primary' | ||
| source, and may have any number of 'aggregator' or 'supporting data' | ||
| sources. | ||
| enum: |
There was a problem hiding this comment.
should these have biolink: prefixes?
There was a problem hiding this comment.
edeutsch
left a comment
There was a problem hiding this comment.
however, the build is failing because you have exceeded the dreaded 79 character limit.
|
super-fussy yamllint is still unhappy with this PR: |
| - primary knowledge source | ||
| - aggregator knowledge source | ||
| - supporting data source | ||
| previous_resource: |
There was a problem hiding this comment.
maybe "upstream_resources" would be better?
- upstream seems better than "previous"?
- plural since an array?
remove trailing whitespaces, Edge.sources array minItems: 1, previous_resource -> upstream_resources, snake case enum values
|
Automatic checks are still failing. I think the problem is that on line 1124 there is an unclosed quote |
|
The automatic build is still failing. The goal would be to ensure that the automatic validation passes. |
|
Replaced with PR #393 (in which @sierra-moxon fixed syntax errors that were causing test failures, and made resourceRole an object to reference so that it can leverage biolink enums) |
Adding RetrievalSource object (and a reference to it form Edge) to support richer representations of retrieval provenance per #369.