[Order 04][P1] Fix Oracle CommitStampStart recursion after Oracle tests are enabled

[AGiorgetti]

Priority order

Order: 04 of 09
Priority: P1 correctness
Blocked by: #58

Problem

OracleNativeDialect.CommitStampStart recursively calls itself.

Evidence:

• src/NEventStore.Persistence.Sql/SqlDialects/OracleNativeDialect.cs:55
• Getter calls MakeOracleParameter(CommitStampStart) instead of MakeOracleParameter(base.CommitStampStart).

Impact

Oracle date-range reads that need CommitStampStart can stack overflow before executing SQL.

Mandatory test-first workflow

• Complete [Order 03][P1] Research and enable Oracle integration test infrastructure #58 first or explicitly document why Oracle tests still cannot run.
• Add tests before changing production code.
• At minimum, add a unit test against new OracleNativeDialect().CommitStampStart.
• Add or enable Oracle integration coverage for GetFromTo(bucketId, startDate, endDate) once Oracle tests can run.

Proposed action

• Change the getter to MakeOracleParameter(base.CommitStampStart).

Acceptance criteria

• Oracle CommitStampStart returns :CommitStampStart without recursion.
• Oracle date-range read tests pass when Oracle test infrastructure is available.
• No Oracle production-code fix is merged before the test prerequisite is addressed.

Source: docs/Project-Analysis-Issue-Drafts.md.

[AGiorgetti]

Implemented and validated locally for issue #61.

Summary:

• Added Oracle regression coverage in src/NEventStore.Persistence.Oracle.Tests/OracleCommitStampStartTests.cs.
• Added a direct dialect test verifying new OracleNativeDialect().CommitStampStart returns :CommitStampStart without recursion.
• Added Oracle integration coverage for GetFromTo(bucketId, startDate, endDate) to verify date-range reads execute and return only commits inside the requested timestamp range.
• Fixed OracleNativeDialect.CommitStampStart to use base.CommitStampStart before Oracle parameter conversion.
• While validating the integration regression, found Oracle was still falling back to common LIMIT/OFFSET SQL for GetCommitsFromToInstant; added an Oracle-native date-range statement and override.

Test-first evidence:

• The new Oracle date-range regression crashed the test host before the fix with a stack overflow in OracleNativeDialect.get_CommitStampStart.
• After the getter fix, the same regression exposed the missing Oracle-native date-range SQL with ORA-00936; adding GetCommitsFromToInstant fixed that path.

Validation:

• dotnet test .\src\NEventStore.Persistence.Oracle.Tests\NEventStore.Persistence.Oracle.Core.Tests.csproj -c Release -f net8.0 --no-build --filter "FullyQualifiedName~when_getting_the_oracle_commit_stamp_start_parameter"
  • Result: 1 passed, 0 failed, 0 skipped.
• dotnet test .\src\NEventStore.Persistence.Oracle.Tests\NEventStore.Persistence.Oracle.Core.Tests.csproj -c Release -f net8.0 --no-restore --filter "FullyQualifiedName~CommitStampStart|FullyQualifiedName~when_reading_oracle_commits_between_commit_stamps"
  • Result: 2 passed, 0 failed, 0 skipped.
• dotnet test .\src\NEventStore.Persistence.Oracle.Tests\NEventStore.Persistence.Oracle.Core.Tests.csproj -c Release -f net8.0 --no-build
  • Result: 146 passed, 0 failed, 0 skipped.
• dotnet build .\src\NEventStore.Persistence.Sql.Core.sln -c Release --no-restore /p:ContinuousIntegrationBuild=true -m:1 -nr:false
  • Result: passed.

Docs updated:

• docs/Project-Analysis-Issue-Drafts.md now includes the [Order 04][P1] Fix Oracle CommitStampStart recursion after Oracle tests are enabled #61 handoff notes.

No files under dependencies/ were modified.