feat: added secret expiry alerts and switch action group email to pipeline variables #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification |
nc-shahidazim
changed the title
nc-shahidazim
changed the title
rfk-nc
previously approved these changes
Jan 28, 2026
nc-shahidazim
force-pushed
the
feat/DTOSS-12086-alert-secrets-expiry
branch
from
6d74540 to
c8743c0
Compare
nc-shahidazim
force-pushed
the
feat/DTOSS-12086-alert-secrets-expiry
branch
from
c8743c0 to
325feaa
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the secret expiry alerting feature introduced in the shared Key Vault module and removes the now‑unnecessary Key Vault dependency from the monitor action group module. Alerts are now configured directly through the module inputs, and the action group email configuration is supplied via pipeline variables instead of Key Vault.
Context
This repository already uses the shared Key Vault module but did not previously consume its new capability to generate alerts for expired or near‑expiry secrets. In addition, the monitor action group module historically depended on Key Vault to retrieve the monitoring email address. This created an unnecessary coupling and required secret lookups during deployment.
A recent update moved the monitoring email address into Azure DevOps environment variables, eliminating the need for the module to reference Key Vault.
What’s Included
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.