Skip to content

Conversation

@fdiblen
Copy link
Member

@fdiblen fdiblen commented Apr 20, 2021

Refs: #169 #162 #178

@fdiblen fdiblen marked this pull request as ready for review April 20, 2021 15:37
fdiblen and others added 2 commits April 20, 2021 17:42
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
Copy link

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of changes but overall great job! 🦅

@jspaaks
Copy link

jspaaks commented Apr 20, 2021

.mlc-config.json can be used to add a couple of exceptions, like 👍

ERROR: 3 dead links found!
[✖] https://doi.org/<replace-with-created-DOI> → Status: 404
[✖] https://bestpractices.coreinfrastructure.org/projects/<replace-with-created-project-identifier> → Status: 404
[✖] https://bestpractices.coreinfrastructure.org/projects/<replace-with-created-project-identifier>/badge → Status: 404

@fdiblen fdiblen requested a review from jspaaks April 20, 2021 16:10
Copy link

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 yay

@fdiblen fdiblen merged commit 2201bd5 into main Apr 20, 2021
@fdiblen fdiblen deleted the 162-use-markdown branch April 20, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants