Make linting a separate job on CI #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Can someone please review and/or merge? The markdown link check was not something changed in this PR, so all tests pass. |
abelsiqueira
requested changes
Dec 15, 2021
Member
abelsiqueira
left a comment
abelsiqueira
left a comment
There was a problem hiding this comment.
Hi @egpbos, thanks for the review. I made a small correction.
The changes were tested by using using your branch with cookiecutter and pushing the changes to a temporary repo.
After the fix, feel free to merge. 👍
Co-authored-by: Abel Siqueira <nepper271@gmail.com>
abelsiqueira
approved these changes
Dec 15, 2021
Member
abelsiqueira
left a comment
abelsiqueira
left a comment
There was a problem hiding this comment.
Thanks! I don't have write permissions, so feel free to merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting is currently done on the whole build matrix. By taking it out and giving it a separate job, we save some resources (linting only needs to be run once, the code doesn't change based on OS or Python version) and make the actual build jobs fail only on tests, not on linting, making the Actions overview easier to quickly check.