Skip to content

Handle double quotes in name and description. #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lyashevska merged 1 commit into from
Aug 15, 2024
Merged

Handle double quotes in name and description. #414

lyashevska merged 1 commit into from
Aug 15, 2024

Conversation

@lyashevska
Copy link
Collaborator

@lyashevska lyashevska commented Aug 1, 2024 •
edited
Loading

Description

This PR handles double quotes in full_name and `package_short_description' which was originally in cookiecutter hooks.

    "full_name": cookiecutter.full_name.replace('\"', '\\\"'),
    "package_short_description": cookiecutter.package_short_description.replace('\"', '\\\"')

Related issues:

@lyashevska lyashevska requested a review from sjvrijn August 1, 2024 19:53
sjvrijn
sjvrijn reviewed Aug 5, 2024
View reviewed changes
sjvrijn
sjvrijn approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@sjvrijn sjvrijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lyashevska lyashevska merged commit 7d573c5 into dev Aug 15, 2024
@lyashevska lyashevska deleted the 407-add-validators branch August 15, 2024 09:55
@lyashevska lyashevska mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjvrijn sjvrijn sjvrijn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lyashevska @sjvrijn