Skip to content

Conversation

@lyashevska
Copy link
Collaborator

Handle double quotes in name and description.Description

Related issues:

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made some comments.

Comment on lines +86 to 87
If your Python package was created successfully, `copier` will point you to a file
(`my-python-project/next_steps.md`) that contains information on next steps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true?

Copy link
Collaborator Author

@lyashevska lyashevska Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we leave it for now, this will be addressed in #409

lyashevska and others added 2 commits August 15, 2024 14:07
Co-authored-by: Abel Soares Siqueira <abel.s.siqueira@gmail.com>
Co-authored-by: Abel Soares Siqueira <abel.s.siqueira@gmail.com>
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

@lyashevska
Copy link
Collaborator Author

Thanks for your review and recommendations @abelsiqueira

@lyashevska lyashevska merged commit 3ae01a3 into dev Aug 15, 2024
@lyashevska lyashevska deleted the update-copier-readme.dev.md branch August 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants