Update PR template test instructions to use copier #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjvrijn
force-pushed
the
417-update-gh-pr-template
branch
from
2ea1aba to
41177d8
Compare
fdiblen
approved these changes
Aug 19, 2024
lyashevska
reviewed
Aug 19, 2024
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
lyashevska
reviewed
Aug 19, 2024
| # Create a temporary directory in /tmp, keep the XXXXXX in the directory name | ||
| cd $(mktemp -d --tmpdir py-tmpl-XXXXXX) | ||
| cookiecutter -c <pr-branch> https://github.com/<pr-user>/python-template | ||
| # Use --vcs-ref <pr-branch> to point to the branch to you want to test |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Use --vcs-ref <pr-branch> to point to the branch to you want to test | |
| # Use --vcs-ref <pr-branch> to point to the branch you want to test |
lyashevska
approved these changes
Aug 19, 2024
Collaborator
lyashevska
left a comment
lyashevska
left a comment
There was a problem hiding this comment.
Thanks @sjvrijn Looks good, I made a few suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap out the old
cookiecutterCLI instructions with the newcopierinstructions, specifically thecopier copycommand pointing to the branch for the PR.Fixes #417