Skip to content

Conversation

@fdiblen
Copy link
Member

@fdiblen fdiblen commented Aug 23, 2024

Checklist

Description

This PR

  • groups the questions in dedicated yaml files
  • selects the default features for the recommended profile
  • adds a submenu for GitHub Actions
  • adds a submenu for Citation
  • adds help field to questions missing this field
  • adds a default value for package version

**Known problems:

Related issues:

Instructions to review the pull request

Step-1: Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Step-2: Create a package

copier copy --vcs-ref 535_menu_and_profiles https://github.com/nlesc/python-template test_menu

Step-3: Test the features
Repeat Step-2 for each feature individually and check

  • if the expected files are created
  • expected text is present (e.g. if you select citation, related text should be present)

If you see something unexpected, add it to your review and create a GitHub issue.

@fdiblen fdiblen marked this pull request as ready for review August 26, 2024 13:08
@fdiblen fdiblen requested review from lyashevska and sjvrijn August 26, 2024 13:08
@lyashevska
Copy link
Collaborator

lyashevska commented Aug 26, 2024

Results of the testing:

  • recommended and let me choose profile have the same structure as minimum, no new features are being added when selected. This behaviour is introduced with this PR.

Copy link
Collaborator

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fdiblen. Great work. Almost there! Please check #570

@lyashevska lyashevska self-requested a review August 27, 2024 09:24
Copy link
Collaborator

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments. Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants