Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [Unreleased]

### Added
* Make editorconfig optional [#571](https://github.com/NLeSC/python-template/pull/571)
* Make contributing guidelines optional [#465]()
* Make developer documentation optional [#467](https://github.com/NLeSC/python-template/pull/541)
* Make Code of Conduct optional [#464](https://github.com/NLeSC/python-template/pull/530)
Expand Down
11 changes: 8 additions & 3 deletions copier/questions/features_code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ SelectCodeQualityFeatures:
type: yaml
default: |-
{% if template_profile == 'recommended' %}
[SelectGitHubActions_flag, not_implemented_linting, AddSonarCloud_flag, not_implemented_editor_config]
[SelectGitHubActions_flag, not_implemented_linting, AddSonarCloud_flag, AddEditorConfig_flag]
{%- else -%}
[]
{%- endif %}
Expand All @@ -26,8 +26,8 @@ SelectCodeQualityFeatures:
Code analysis (using SonarCloud):
value: AddSonarCloud_flag
# validator: "{% if something != 'AnotherThing' %}BlaBla{% endif %}"
Editorconfig (NOT_IMPLEMENTED):
value: not_implemented_editor_config
Editorconfig:
value: AddEditorConfig_flag
# validator: "{% if something != 'AnotherThing' %}BlaBla{% endif %}"


Expand Down Expand Up @@ -80,3 +80,8 @@ AddSonarCloud:
type: bool
default: "{{ 'AddSonarCloud_flag' in SelectCodeQualityFeatures }}"
when: false

AddEditorConfig:
type: bool
default: "{{ 'AddEditorConfig_flag' in SelectCodeQualityFeatures }}"
when: false
File renamed without changes.