Skip to content

Attempt to have docs autogenerate and deploy to webpage#7

Merged
danielballan merged 4 commits into
NSLS-II-SIX:masterfrom
awalter-bnl:auto_generate_sphinx
Jul 19, 2018
Merged

Attempt to have docs autogenerate and deploy to webpage#7
danielballan merged 4 commits into
NSLS-II-SIX:masterfrom
awalter-bnl:auto_generate_sphinx

Conversation

@awalter-bnl

@awalter-bnl awalter-bnl commented Jul 17, 2018

Copy link
Copy Markdown
Contributor

Add auto-generation and publication to a website for the documentation. this covers issue #6 and I will duplicate this in scikit-beam/rixs once it is merged here.

@codecov-io

codecov-io commented Jul 17, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   43.26%   43.26%           
=======================================
  Files           3        3           
  Lines         282      282           
=======================================
  Hits          122      122           
  Misses        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5159a3...f27c575. Read the comment docs.

@awalter-bnl awalter-bnl requested a review from danielballan July 17, 2018 13:14
@awalter-bnl

Copy link
Copy Markdown
Contributor Author

In this PR I am attempting to have the docs for NSLS-II-SIX/sixtools autogenerate the docs and publish them to a webpage. I attempted to use the instructions here and the .travis.yaml file in NSLS-II/bluesky as an example.

Any feedback on what I did wrong is appreciated.

Comment thread .travis.yml
- coverage report -m # Generate test coverage report.
- codecov # Upload the report to codecov.
- flake8 --max-line-length=115 # Enforce code style (but relax line length limit a bit).
- make -C docs html # Build the documentation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave this line as it was and just add set -e and doctor deploy ... The $BUILD_DOCS stuff is an old pattern that I would no longer recommend.

Comment thread .travis.yml Outdated
make html
popd
#publish docs
doctr deploy --deploy-repo NSLS-II-SIX/NSLS-II-SIX.github.io --deploy-branch-name master sixtools

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This --deploy-repo NSLS-II-SIX/NSLS-II-SIX.github.io --deploy-branch-name master customization (incidentally, added by me -- see PR for context on what this is doing) isn't necessary unless we want to go the route of one centralized target for built artifacts. We do that for NSLS-II/* repos, but it probably is overkills for SIX.

@awalter-bnl

Copy link
Copy Markdown
Contributor Author

Thanks for the review @danielballan, and the description of why using the NSLS-II approach is not needed here. I have made the suggested changes

Comment thread .travis.yml Outdated
- set -e # Stop here if anything fails above
- make -C docs html # Build the documentation
- pip install doctr
- doctr deploy --built-docs docs/build/html # Publish the documentation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis failed because this is missing the target directory to deploy the HTML into. Add ..

- doctr deploy --built-docs docs/build/html . # Publish the documentation

Adding the root directory `.` to the end
@danielballan danielballan merged commit 352208c into NSLS-II-SIX:master Jul 19, 2018
@awalter-bnl awalter-bnl deleted the auto_generate_sphinx branch July 19, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants