Skip to content

ENH:Attempt to add timeout to get, put, post#2

Merged
Dan Allan (danielballan) merged 2 commits into
masterfrom
unknown repository
Jun 1, 2016
Merged

ENH:Attempt to add timeout to get, put, post#2
Dan Allan (danielballan) merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost

Copy link
Copy Markdown

No description provided.

@ghost

Copy link
Copy Markdown
Author

Dan Allan (@danielballan) give this a shot

@danielballan

Copy link
Copy Markdown

That looks good. I took a quick look at the docs for request and read, in this section, "it is good practice to set your timeout to slightly larger than a multiple of 3 [seconds], which is the default TCP transmission window." Would 3.5 be a better default value than 2?

@ghost

Copy link
Copy Markdown
Author

Thomas A Caswell (@tacaswell) and I picked 2, we were off by a second and a half :). I think even 4.5 wouldn't hurt given olog also authenticates. I will test it and make the corresponding changes to the PR

@ghost

Copy link
Copy Markdown
Author

attn Dan Allan (@danielballan)

@danielballan Dan Allan (danielballan) merged commit 2c9a793 into NSLS2:master Jun 1, 2016
@danielballan

Copy link
Copy Markdown

Attn cmazzoli This should solve the issue with the Olog subscription hanging scans. If the Olog does not respond after ~4 seconds, an error will be raised in Python. The RunEngine will catch that error, print a warning, and continue with the scan.

@danielballan

Dan Allan (danielballan) commented Jun 6, 2016

Copy link
Copy Markdown

attn arkilic By coincidence, when I visited CSX to install the updated pyolog, the Olog happened to be down (what are the odds?!) and so I had the opportunity to test that, with this upgrade, bluesky is able to run the scan after a ~5 second delay, showing a warning about a ReadTImeoutError.

@ghost

Copy link
Copy Markdown
Author

Mission accomplished with a 27 character commit 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant