Update imports in dispatch module to handle missing GPU #99
Merged
karlhigley merged 1 commit intoNVIDIA-Merlin:mainfrom Jun 8, 2022
Merged
Conversation
e9dd7d3 to
8068cfe
Compare
8068cfe to
eaf8cae
Compare
Documentation preview |
karlhigley
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use HAS_GPU in dispatch module to avoid some imports that raise exceptions. Followup to #98
Motivation
Importing the dispatch module without GPU available (e.g. in a docker container running without gpu configuration) raises an exception.
This module is imported by merlin.systems and makes it more difficult to experiment with triton without GPU features enabled.
Results in the following error (partial error output)
Implementation Details
The
dask_cudfimport is the one responsible for the exception. And theRuntimeErrorraised cannot be caught with a simple try/except.This PR wraps some of the imports with a check for the
HAS_GPUvariable from the compat module added in #98