-
Notifications
You must be signed in to change notification settings - Fork 199
fix(docs): unbreak published Fern site #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
47d2cc6
fix(docs): shrink inline base64 images in notebook HTML outputs
lbliii afadf1c
fix(docs): migrate leftover MkDocs tab syntax to Fern Tabs
lbliii afa7f68
fix(docs): convert leftover MkDocs admonition to Fern Tip
lbliii 8340272
Merge branch 'main' into lbliii/fix-fern-published-docs
andreatnvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
fern/components/notebooks/6-editing-images-with-image-context.json
Large diffs are not rendered by default.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
fern/components/notebooks/6-editing-images-with-image-context.ts
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INLINE_DATA_URI_REincludes\sin the character class so the capture group can span whitespace-wrapped base64, and_subeven calls"".join(match.group(2).split())to strip that whitespace. However, the lazy quantifier+?combined with\sin the lookahead(?=["'\s)])means the match terminates at the first whitespace it encounters — so\sin the character class is never reachable and the whitespace-stripping in_subis always a no-op. If a future notebook emits pretty-printed HTML with line-wrapped base64 (e.g.src='data:image/png;base64,\nAAA...), the regex captures only the empty prefix before the newline, passes garbage toshrink_image_b64, which fails silently and returns an empty string, and the replacement produces a brokendata:image/jpeg;base64,URI.Prompt To Fix With AI