Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fern/docs.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
instances:
- url: datadesigner.docs.buildwithfern.com/nemo/datadesigner
custom-domain: docs.nvidia.com/nemo/datadesigner
multi-source: true
title: NVIDIA NeMo Data Designer

# NVIDIA branding (logo, favicon, colors, fonts, footer, base CSS/JS, layout) is
Expand All @@ -26,7 +27,6 @@ navbar-links:
experimental:
mdx-components:
- ./components
Comment on lines 27 to 29

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Undocumented removal of basepath-aware: true

The PR description only mentions adding multi-source: true, but basepath-aware: true has also been silently removed from the experimental block. This flag was presumably added intentionally — the file already notes issues with silently-dropped experimental config (#713/#715). If basepath-aware is no longer needed because multi-source handles path resolution, it would be worth a one-line note in the description. If it was removed accidentally, relative link resolution in MDX components could regress.

Prompt To Fix With AI
This is a comment left during a code review.
Path: fern/docs.yml
Line: 27-29

Comment:
**Undocumented removal of `basepath-aware: true`**

The PR description only mentions adding `multi-source: true`, but `basepath-aware: true` has also been silently removed from the `experimental` block. This flag was presumably added intentionally — the file already notes issues with silently-dropped experimental config (`#713`/`#715`). If `basepath-aware` is no longer needed because `multi-source` handles path resolution, it would be worth a one-line note in the description. If it was removed accidentally, relative link resolution in MDX components could regress.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

basepath-aware: true
versions:
- display-name: "Latest"
path: versions/latest.yml
Expand Down
Loading