Validate server port selection #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
2 tasks
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
…selection Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
bxyu-nvidia
requested changes
Oct 25, 2025
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
…selection Signed-off-by: Frankie Siino <fsiino@nvidia.com> # Conflicts: # nemo_gym/global_config.py
bxyu-nvidia
approved these changes
Oct 28, 2025
lbliii
pushed a commit
that referenced
this pull request
Nov 3, 2025
This change adds retry logic to the server spin up process via `ng_run` in the event that there is a port conflict between the head and child(ren) server(s). --------- Signed-off-by: Frankie Siino <fsiino@nvidia.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
lbliii
pushed a commit
that referenced
this pull request
Nov 3, 2025
This change adds retry logic to the server spin up process via `ng_run` in the event that there is a port conflict between the head and child(ren) server(s). --------- Signed-off-by: Frankie Siino <fsiino@nvidia.com>
lbliii
pushed a commit
that referenced
this pull request
Nov 3, 2025
This change adds retry logic to the server spin up process via `ng_run` in the event that there is a port conflict between the head and child(ren) server(s). --------- Signed-off-by: Frankie Siino <fsiino@nvidia.com>
lbliii
pushed a commit
that referenced
this pull request
Nov 3, 2025
This change adds retry logic to the server spin up process via `ng_run` in the event that there is a port conflict between the head and child(ren) server(s). --------- Signed-off-by: Frankie Siino <fsiino@nvidia.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
lbliii
pushed a commit
that referenced
this pull request
Nov 3, 2025
This change adds retry logic to the server spin up process via `ng_run` in the event that there is a port conflict between the head and child(ren) server(s). --------- Signed-off-by: Frankie Siino <fsiino@nvidia.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds retry logic to the server spin up process via
ng_runin the event that there is a port conflict between the head and child(ren) server(s).