Expose server host and port in dataset viewer CLI #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadki
force-pushed
the
ahmadki/fix_126
branch
from
359a7c6 to
65b5264
Compare
Member
Author
|
If we keep |
bxyu-nvidia
requested changes
Dec 10, 2025
Signed-off-by: Ahmad Kiswani <kiswani.ahmad@gmail.com>
ahmadki
force-pushed
the
ahmadki/fix_126
branch
from
65b5264 to
f11f5bd
Compare
bxyu-nvidia
requested changes
Dec 10, 2025
| :::{tip} | ||
| **Configuring Network Access** | ||
|
|
||
| By default, the viewer accepts requests only from localhost (`server_host=127.0.0.1`). To make it accessible on your local network: |
Contributor
There was a problem hiding this comment.
can we change
To make it accessible on your local network:
to
To make it accessible on beyond your local network or accessible from a different machine:
Signed-off-by: Ahmad Kiswani <kiswani.ahmad@gmail.com>
bxyu-nvidia
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/NVIDIA-NeMo/Internal-Planning/issues/126
@bxyu-nvidia Per the issue, the PR also changes the default
server_hostto0.0.0.0(accessible from everywhere). But I would advise against this for security reasons. I think keeping the default to127.0.0.1is the right call even if the user needs to modify the command to access the server.