ASE-702: Make analyst/experimentalist/eval-author CLI agents-only - #1052
ASE-702: Make analyst/experimentalist/eval-author CLI agents-only#1052aleckhoury wants to merge 2 commits into
Conversation
Drop legacy top-level aliases and document only `nemo agents …` paths so the optimizer plugins match the platform agent CLI naming. Signed-off-by: Alec Khoury <akhoury@nvidia.com>
📝 WalkthroughWalkthroughThe CLI plugins now use ChangesCLI registration and command migration
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
Drop entry-point and fake AgentsCLI mount coverage; keep verb placeholders and a single ctx.command_path check. Signed-off-by: Alec Khoury <akhoury@nvidia.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
plugins/nemo-eval-author/tests/test_cli.py (1)
4-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRestore coverage for the real Eval Author command registration.
The new test creates a fresh Typer app and registers a synthetic
probe. It never loads the Eval Author CLI or the realnemoroot. It can pass when thenemo.cli.agentsentry point is missing,eval-authorremains top-level, or the nested path is incorrect. Keep this unit test for_not_implemented, but add a metadata or root-CLI test fornemo agents eval-author ...and a rejection check fornemo eval-author ....Based on the stated nested-agent registration objective and the listed removal of entry-point and legacy-path tests.
Also applies to: 27-27, 44-59
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/nemo-eval-author/tests/test_cli.py` at line 4, Extend the tests beyond the synthetic Typer app and `_not_implemented` probe to load the real Eval Author registration through the `nemo` root CLI and `nemo.cli.agents`. Verify `eval-author` is available under the nested `nemo agents` command path, and add a rejection check confirming the legacy top-level `nemo eval-author` path is not accepted.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@plugins/nemo-eval-author/tests/test_cli.py`:
- Line 4: Extend the tests beyond the synthetic Typer app and `_not_implemented`
probe to load the real Eval Author registration through the `nemo` root CLI and
`nemo.cli.agents`. Verify `eval-author` is available under the nested `nemo
agents` command path, and add a rejection check confirming the legacy top-level
`nemo eval-author` path is not accepted.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ffffcbcb-29f0-4b70-b2ce-730ef958c028
📒 Files selected for processing (1)
plugins/nemo-eval-author/tests/test_cli.py
Summary
nemo experimentalist,nemo eval-author,nemo insights analyze|doctor) so these agents live only undernemo agents …nemo insights analysis/analyze-joband leave eval-author placeholder verbs unimplementedFixes ASE-702.
Test plan
uv run nemo agents --helpshows analyst / experimentalist / eval-author under Platform agentsuv run nemo insights --helphasanalysisandanalyze-job, notanalyze/doctoruv run nemo experimentalist --help/nemo eval-author --helpfail (no such command)test_cli_profile, eval-authortest_cli, experimentalist CLI testsInsightOpenModalunit test expectsnemo agents experimentalist runSummary by CodeRabbit
Changed
nemo agentsnamespace.Documentation
Tests