chore: Bump data-designer and anonymizer library versions - #659
Merged
Conversation
Contributor
|
🌿 Preview your docs: https://nvidia-preview-dd-anon-bump-mknepper.docs.buildwithfern.com/nemo-platform |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesData Designer upgrade
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
plugins/nemo-data-designer/tests/unit/test_preview_function.py (1)
27-29: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUpdate the obsolete provider-resolution bypass.
The fixture now includes
provider="default/nvidia", but_patch_preview_dependencies()still describes it as provider-less and replaces model extraction with[]. This hides the new provider-resolution path; either update the rationale and add separate coverage, or remove the bypass if resolution belongs in this test.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/nemo-data-designer/tests/unit/test_preview_function.py` around lines 27 - 29, Update _patch_preview_dependencies() to stop treating the fixture’s ModelConfig as provider-less now that provider="default/nvidia" is set. Remove the model-extraction bypass so the test exercises provider resolution, or revise the rationale and add dedicated coverage that validates the new provider-resolution path.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/nemo-data-designer/pyproject.toml`:
- Line 50: Run refresh-data-designer-skill using the updated
data-designer==0.7.0 pins in plugins/nemo-data-designer/pyproject.toml,
regenerating third_party/requirements-main.txt so it removes the stale 0.6.1,
data-designer-config, and data-designer-engine entries. Apply the same generated
synchronization for packages/data_designer_nemo/pyproject.toml,
packages/nemo_platform/pyproject.toml at lines 90-90, 246-246, and 267-267,
plugins/nemo-anonymizer/pyproject.toml, and
plugins/nemo-data-designer/pyproject.toml at lines 10-10; do not edit generated
requirements by hand.
---
Nitpick comments:
In `@plugins/nemo-data-designer/tests/unit/test_preview_function.py`:
- Around line 27-29: Update _patch_preview_dependencies() to stop treating the
fixture’s ModelConfig as provider-less now that provider="default/nvidia" is
set. Remove the model-extraction bypass so the test exercises provider
resolution, or revise the rationale and add dedicated coverage that validates
the new provider-resolution path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6b257676-1062-4f74-96ad-f87b50c215b7
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (17)
docs/data-designer/index.mdxdocs/data-designer/migration.mdxdocs/data-designer/tutorials/basics.mdxdocs/data-designer/tutorials/index.mdxdocs/data-designer/tutorials/seeding.mdxpackages/data_designer_nemo/pyproject.tomlpackages/data_designer_nemo/src/data_designer_nemo/model_provider.pypackages/data_designer_nemo/tests/unit/test_fileset_file_seed_reader.pypackages/data_designer_nemo/tests/unit/test_model_configs.pypackages/nemo_platform/pyproject.tomlplugins/nemo-anonymizer/pyproject.tomlplugins/nemo-data-designer/pyproject.tomlplugins/nemo-data-designer/tests/integration/test_remote_validation_errors.pyplugins/nemo-data-designer/tests/unit/test_model_provider.pyplugins/nemo-data-designer/tests/unit/test_preview_function.pyplugins/nemo-data-designer/tests/unit/test_sdk_resources.pypytest.ini
💤 Files with no reviewable changes (2)
- plugins/nemo-data-designer/tests/unit/test_model_provider.py
- plugins/nemo-data-designer/tests/integration/test_remote_validation_errors.py
Contributor
|
mikeknep
force-pushed
the
dd-anon-bump/mknepper
branch
from
July 13, 2026 21:44
70f7dde to
a4b2205
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
plugins/nemo-data-designer/openapi/openapi.yaml (1)
687-747: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winNew anonymizer schemas lack docstrings.
ChunkedValidationConfig,DetectionTransformConfig, andDetectionTransformOperationhave nodescriptionfield, unlike every other column-config schema in this file (all have detailed Attributes docs). Since this is generated from Pydantic docstrings, add docstrings to the underlying model classes for consistency and better generated API docs.Also applies to: 1212-1253
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/nemo-data-designer/openapi/openapi.yaml` around lines 687 - 747, The underlying Pydantic model classes for ChunkedValidationConfig, DetectionTransformConfig, and DetectionTransformOperation lack documentation docstrings. Add detailed class docstrings describing each model’s purpose and attributes so schema generation emits a description field, matching the other column-config models; do not edit the generated OpenAPI YAML directly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@plugins/nemo-data-designer/openapi/openapi.yaml`:
- Around line 687-747: The underlying Pydantic model classes for
ChunkedValidationConfig, DetectionTransformConfig, and
DetectionTransformOperation lack documentation docstrings. Add detailed class
docstrings describing each model’s purpose and attributes so schema generation
emits a description field, matching the other column-config models; do not edit
the generated OpenAPI YAML directly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c7301990-e65c-4c27-aaff-8166a88d0260
📒 Files selected for processing (4)
.github/wheel-constraints/nemo-platform-services.txtplugins/nemo-data-designer/openapi/openapi.yamlthird_party/osv-licenses.jsonthird_party/requirements-main.txt
mckornfield
approved these changes
Jul 13, 2026
mikeknep
force-pushed
the
dd-anon-bump/mknepper
branch
from
July 14, 2026 13:43
10bde1c to
5086851
Compare
Contributor
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
script/generate_openapi_spec.py (1)
328-357: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winTest the global entry-point override.
Add coverage for filtering the target group, preserving other groups, and restoration after an exception.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@script/generate_openapi_spec.py` around lines 328 - 357, Add tests for data_designer_plugin_allowlist covering filtering data_designer.plugins to only allowed names, returning unrelated entry-point groups unchanged, and restoring importlib.metadata.entry_points when the context exits through an exception.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@script/generate_openapi_spec.py`:
- Around line 328-357: Add tests for data_designer_plugin_allowlist covering
filtering data_designer.plugins to only allowed names, returning unrelated
entry-point groups unchanged, and restoring importlib.metadata.entry_points when
the context exits through an exception.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0353c99a-c172-41f8-864a-32110c843b1f
📒 Files selected for processing (6)
plugins/nemo-anonymizer/tests/unit/test_run_job.pyplugins/nemo-data-designer/openapi/openapi.yamlplugins/nemo-data-designer/pyproject.tomlscript/generate_openapi_spec.pyscript/openapi_helper/plugin_config.pytests/unit/test_plugin_openapi_config.py
💤 Files with no reviewable changes (1)
- plugins/nemo-data-designer/openapi/openapi.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- plugins/nemo-data-designer/pyproject.toml
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
mikeknep
force-pushed
the
dd-anon-bump/mknepper
branch
from
July 14, 2026 14:56
9d7e447 to
ed6dd31
Compare
mikeknep
enabled auto-merge
July 14, 2026 15:01
svvarom
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.7.0and anonymizer to0.3.0As of DD 0.7.0, model configs require an explicit provider, and the model provider registry no longer recognizes/accepts/declares a default. Most of the deletions here are removing logic and tests related to the previous default behavior.
Summary by CodeRabbit
allow_resizefrom multiple column configs; clarifiedModelConfig.providerwording).