ci: correct the blank SHA case for releases - #660
Merged
Conversation
Signed-off-by: Brooke Storm <brookes@nvidia.com>
svvarom
self-requested a review
July 13, 2026 21:32
svvarom
marked this pull request as ready for review
July 13, 2026 21:32
svvarom
reviewed
Jul 13, 2026
svvarom
left a comment
Contributor
There was a problem hiding this comment.
LGTM. For context https://github.com/NVIDIA-NeMo/nemo-platform/actions/runs/29286104607
crookedstorm
enabled auto-merge
July 13, 2026 21:34
Contributor
📝 WalkthroughWalkthroughThe release workflow updates dispatch input descriptions, makes optional release-plan inputs null-safe, and adds a Git ancestry check requiring the selected source SHA to precede the workflow revision. ChangesRelease workflow
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yaml:
- Around line 59-64: Correct the description for the update-ngc-metadata
workflow input by removing the duplicated article, changing “from the this
branch” to “from this branch” or equivalent wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7f36baa5-67e4-4dad-aa2a-2c60a1074067
📒 Files selected for processing (1)
.github/workflows/release.yaml
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Documentation