Skip to content

ci: correct the blank SHA case for releases - #660

Merged
crookedstorm merged 1 commit into
mainfrom
correct-release-setup/crookedstorm
Jul 13, 2026
Merged

ci: correct the blank SHA case for releases#660
crookedstorm merged 1 commit into
mainfrom
correct-release-setup/crookedstorm

Conversation

@crookedstorm

@crookedstorm crookedstorm commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Improved release workflow handling when an optional source revision is not provided.
    • Added validation to prevent releases from using a source revision unrelated to the selected workflow revision.
  • Documentation

    • Clarified release input descriptions for selective Helm artifact inclusion and NGC metadata synchronization.

Signed-off-by: Brooke Storm <brookes@nvidia.com>
@crookedstorm crookedstorm self-assigned this Jul 13, 2026
@github-actions github-actions Bot added the ci label Jul 13, 2026
@svvarom
svvarom self-requested a review July 13, 2026 21:32
@svvarom
svvarom marked this pull request as ready for review July 13, 2026 21:32
@svvarom
svvarom requested a review from a team as a code owner July 13, 2026 21:32

@svvarom svvarom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svvarom svvarom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hit the wrong button

@crookedstorm
crookedstorm enabled auto-merge July 13, 2026 21:34
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The release workflow updates dispatch input descriptions, makes optional release-plan inputs null-safe, and adds a Git ancestry check requiring the selected source SHA to precede the workflow revision.

Changes

Release workflow

Layer / File(s) Summary
Release inputs and plan resolution
.github/workflows/release.yaml
Dispatch descriptions now clarify Helm artifact selection and current-branch NGC metadata synchronization; missing source-sha and version inputs are handled safely.
Source revision ancestry gate
.github/workflows/release.yaml
A post-checkout step fails unless SOURCE_SHA is an ancestor of GITHUB_SHA.

Suggested reviewers: svvarom

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main fix: handling a blank source SHA during release planning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch correct-release-setup/crookedstorm

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yaml:
- Around line 59-64: Correct the description for the update-ngc-metadata
workflow input by removing the duplicated article, changing “from the this
branch” to “from this branch” or equivalent wording.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7f36baa5-67e4-4dad-aa2a-2c60a1074067

📥 Commits

Reviewing files that changed from the base of the PR and between 77d897e and 0e6b2eb.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml

Comment thread .github/workflows/release.yaml
@crookedstorm
crookedstorm added this pull request to the merge queue Jul 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 23853/31009 76.9% 61.7%
Integration Tests 13817/29658 46.6% 19.6%

Merged via the queue into main with commit 96b5c9e Jul 13, 2026
57 checks passed
@crookedstorm
crookedstorm deleted the correct-release-setup/crookedstorm branch July 13, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants