chore: update go, JS and Python deps for High/Crit CVEs - #671
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughDependency constraints were updated across Python packages, Go services, generated dependency metadata, licensing data, advisory data, and the web package. AIPerf installation was isolated from repository uv configuration, and a pnpm override was added. ChangesPython dependency constraints
Go telemetry dependencies
Generated dependency and license metadata
Web dependency override
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/package.json`:
- Line 62: Add the missing test:ci and typecheck scripts to the scripts section
of web/package.json, using vitest run --coverage and tsc --noEmit respectively.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 52e11956-fcdc-4e7e-a1c3-47258835dd16
⛔ Files ignored due to path filters (5)
sdk/python/nemo-platform/pyproject.tomlis excluded by!sdk/**services/core/jobs/jobs-launcher/go.sumis excluded by!**/*.sumservices/guardrails/callouts/go.sumis excluded by!**/*.sumuv.lockis excluded by!**/*.lockweb/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
packages/nemo_evaluator_sdk/pyproject.tomlpackages/nemo_platform/pyproject.tomlplugins/nemo-guardrails/pyproject.tomlpyproject.tomlservices/core/jobs/jobs-launcher/go.modservices/guardrails/callouts/go.modservices/guardrails/pyproject.tomlweb/package.json
|
2173bef to
6ebc2c5
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@third_party/osv-licenses.json`:
- Around line 1433-1673: Update the json-repair dependency from 0.58.7 to
version 0.60.1 or newer in both requirements-main.txt and the pyproject
dependency declarations. Keep the dependency constraints consistent across both
files; only document an explicit security exception instead if the upgrade
cannot be made.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 51f49750-794c-412a-ac80-be262a7b1ad9
⛔ Files ignored due to path filters (5)
sdk/python/nemo-platform/pyproject.tomlis excluded by!sdk/**services/core/jobs/jobs-launcher/go.sumis excluded by!**/*.sumservices/guardrails/callouts/go.sumis excluded by!**/*.sumuv.lockis excluded by!**/*.lockweb/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
packages/nemo_evaluator_sdk/pyproject.tomlpackages/nemo_platform/pyproject.tomlplugins/nemo-guardrails/pyproject.tomlplugins/nemo-guardrails/src/nemo_guardrails_plugin/benchmarks/bootstrap.pypyproject.tomlservices/core/jobs/jobs-launcher/go.modservices/guardrails/callouts/go.modservices/guardrails/pyproject.tomlthird_party/licenses.jsonlthird_party/osv-licenses.jsonthird_party/requirements-main.txttools/nemo-platform-sdk-tools/src/nemo_platform_sdk_tools/license/overrides.yamlweb/package.json
🚧 Files skipped from review as they are similar to previous changes (8)
- web/package.json
- services/guardrails/callouts/go.mod
- packages/nemo_evaluator_sdk/pyproject.toml
- plugins/nemo-guardrails/src/nemo_guardrails_plugin/benchmarks/bootstrap.py
- packages/nemo_platform/pyproject.toml
- pyproject.toml
- plugins/nemo-guardrails/pyproject.toml
- services/core/jobs/jobs-launcher/go.mod
6ebc2c5 to
4cb6302
Compare
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
4cb6302 to
28e032a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@third_party/osv-licenses.json`:
- Around line 877-886: Update the license entries for defusedxml and pandas in
third_party/osv-licenses.json at lines 877-886, 2397-2405, and 6000-6010,
replacing non-standard with PSF-2.0 for defusedxml and BSD-3-Clause for pandas.
Regenerate the summary counts so they reflect the corrected classifications.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: de29bf2e-9f4a-4551-a1c7-1e089bb16c15
⛔ Files ignored due to path filters (5)
sdk/python/nemo-platform/pyproject.tomlis excluded by!sdk/**services/core/jobs/jobs-launcher/go.sumis excluded by!**/*.sumservices/guardrails/callouts/go.sumis excluded by!**/*.sumuv.lockis excluded by!**/*.lockweb/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
packages/nemo_evaluator_sdk/pyproject.tomlpackages/nemo_platform/pyproject.tomlplugins/nemo-guardrails/pyproject.tomlplugins/nemo-guardrails/src/nemo_guardrails_plugin/benchmarks/bootstrap.pypyproject.tomlservices/core/jobs/jobs-launcher/go.modservices/guardrails/callouts/go.modservices/guardrails/pyproject.tomlthird_party/licenses.jsonlthird_party/osv-licenses.jsonthird_party/requirements-main.txttools/nemo-platform-sdk-tools/src/nemo_platform_sdk_tools/license/overrides.yamlweb/package.json
🚧 Files skipped from review as they are similar to previous changes (10)
- tools/nemo-platform-sdk-tools/src/nemo_platform_sdk_tools/license/overrides.yaml
- services/guardrails/pyproject.toml
- web/package.json
- plugins/nemo-guardrails/pyproject.toml
- packages/nemo_evaluator_sdk/pyproject.toml
- third_party/licenses.jsonl
- services/core/jobs/jobs-launcher/go.mod
- plugins/nemo-guardrails/src/nemo_guardrails_plugin/benchmarks/bootstrap.py
- pyproject.toml
- packages/nemo_platform/pyproject.toml
Summary by CodeRabbit
defusedxml, updatingjson-repair, and adjusting tooling/web dependency overrides.uvconstraints.